[AMDGPU] Cluster export instruction in PostRA Scheduler #141399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-amdgpu Author: Carl Ritson (perlfu) ChangesDAG mutation needs to be applied post-RA to maintain order established during pre-RA scheduler. Full diff: https://github.com/llvm/llvm-project/pull/141399.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
index e24d8481408ad..7479703ce353a 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
@@ -1129,6 +1129,7 @@ GCNTargetMachine::createPostMachineScheduler(MachineSchedContext *C) const {
getOptLevel() >= CodeGenOptLevel::Less) &&
EnableVOPD)
DAG->addMutation(createVOPDPairingMutation());
+ DAG->addMutation(createAMDGPUExportClusteringDAGMutation());
return DAG;
}
//===----------------------------------------------------------------------===//
|
perlfu
added a commit
to perlfu/llvm-project
that referenced
this pull request
May 25, 2025
This is a pre-commit test for llvm#141399.
perlfu
force-pushed
the
amdgpu-postra-exp-cluster
branch
from
35b663e to
0eb864e
Compare
arsenm
approved these changes
May 25, 2025
|
Maybe this can only apply post-RA? |
perlfu
added a commit
that referenced
this pull request
May 26, 2025
This is a pre-commit test for #141399.
DAG mutation needs to be applied post-RA to maintain order established during pre-RA scheduler.
perlfu
force-pushed
the
amdgpu-postra-exp-cluster
branch
from
0eb864e to
fba6127
Compare
I think we do need to do this pre-RA as well so RA understands the liveness of the register used for the exports. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/208/builds/1486 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAG mutation needs to be applied post-RA to maintain order established during pre-RA scheduler.